Run-script-before-required: no email in case of error

PDi · June 23, 2024, 4:21pm

Set up:

docker container linuxserver/duplicati running on Debian GNU/Linux 12 (Raspberry Pi) as root (PUID 0, GUID 0)
Mount a host volume for scrips
Create a new tiny backup job
Add the option “run-script-before-required” pointing to a script on the host
Add email notification options (global section)

Test 1:
Let the script return zero
Result:
Success, respective email sent

Test 2:
Let the script return non-zero
Result:
Backup job fails as expected with respected notification in the logs
No email sent

Expected result:
Whenever a mandatory script fails, an appropriate email should be sent

Jojo-1000 · June 23, 2024, 4:33pm

This looks like it is to do with the module loading order. The run script module throws a OperationAbortException to stop the backup from running. This is handled correctly and all the OnFinish methods are called, but because the mail module was not configured before, it does nothing. The proper way to fix this would probably be to configure all modules before calling OnStart.

github.com

duplicati/duplicati/blob/9ca5489ef0694973786adc7f42083b9ea5155e67/Duplicati/Library/Main/Controller.cs#L634-L655


      
          foreach (var mx in LoadedModules)

              if (mx.Key)

              {

                  if (mx.Value is Library.Interface.IConnectionModule)

                      mx.Value.Configure(conopts);

                  else

                      mx.Value.Configure(m_options.RawOptions);

          

                  if (mx.Value is IGenericSourceModule sourcemodule)

                  {

                      if (sourcemodule.ContainFilesForBackup(paths))

                      {

                          var sourceoptions = sourcemodule.ParseSourcePaths(ref paths, ref pristinefilter, m_options.RawOptions);

          

                          foreach (var sourceoption in sourceoptions)

                              m_options.RawOptions[sourceoption.Key] = sourceoption.Value;

                      }

                  }

          

                  if (mx.Value is IGenericCallbackModule module)

This file has been truncated. show original

kenkendk · June 24, 2024, 8:29am

I have made a PR that fixes this.

caco3 · November 23, 2025, 3:22pm

Sorry to warm this up again. It seems that Changed logic so all modules are loaded before any are started by kenkendk · Pull Request #5245 · duplicati/duplicati · GitHub did get closed without a solution.

I have the same issue:
A script in “run-script-before-required“ checks if the preconditions are met. In case of an error, I see the error in Duplicati, so this works.

I also have setup notifications by HTTP:

send-http-form-urls=https://mydomain.com
send-http-level=Warning,Error,Fatal

But it does not get fired. Since the backup is aborted in case of a pre-script-error, this is kind of a fatal issue and I do not see a way to get notified!!