Last month backup listed as This month

Ste · August 27, 2022, 8:17am

Hello,
I think there’s a mistake in ‘This month’ list, it also shows a backup made on July 29th
(we are in August)

avmaksimov · August 27, 2022, 8:48am

I agree with you but also there is bug with “This week” (I see backups created at the prev. week).

drwtsn32 · August 27, 2022, 1:25pm

I’m guessing “this month” means “within the past 30 days”, and “this week” means “within the past 7 days”. That’s what it looks like on my system anyway. “Today” and “Yesterday” seems to be only those calendar days, though. So it’s either a bug or at minimum incorrect labeling.

ts678 · August 27, 2022, 3:25pm

Code is below, for anyone who reads JavaScript well (I do not) or (even better) wants to improve it:

github.com

duplicati/duplicati/blob/666b2281032460254839fdc3b6e1055fdf7ce1db/Duplicati/Server/webroot/ngax/scripts/controllers/RestoreController.js#L23-L48


      
          function createGroupLabel(dt) {
              var dateStamp = function(a) { return a.getFullYear() * 10000 + a.getMonth() * 100 + a.getDate(); }
          
              var now       = new Date();
              var today     = dateStamp(now);
              var yesterday = dateStamp(new Date(new Date().setDate(now.getDate()   - 1)));
              var week      = dateStamp(new Date(new Date().setDate(now.getDate()   - 7)));
              var thismonth = dateStamp(new Date(new Date().setMonth(now.getMonth() - 1)));
              var lastmonth = dateStamp(new Date(new Date().setMonth(now.getMonth() - 2)));
          
              var dateBuckets = [
                  {text: gettextCatalog.getString('Today'), stamp: today},
                  {text: gettextCatalog.getString('Yesterday'), stamp: yesterday},
                  {text: gettextCatalog.getString('This week'), stamp: week},
                  {text: gettextCatalog.getString('This month'), stamp: thismonth},
                  {text: gettextCatalog.getString('Last month'), stamp: lastmonth}
              ];
          
              var stamp = dateStamp(dt);

This file has been truncated. show original

Seems more or less right based on the now.getDate() - 7 seeming to go back 7 days from now.
JavaScript seemingly gives no direct support for going back by weeks, although it does for months.
Month adjust looks rough due to trying to use the same day of month despite varied month lengths.
August and July both have 31 days though, so that might not explain how July 29 wound up in Aug.

JimboJones · August 28, 2022, 1:06pm

Yeah, that’s pretty simple date processing but for most situations it’s probably not a huge issue. Keep in mind this should only be a display issue in the GUI.

A few loops and a couple statements (or put it all in a function) could clean it up pretty quickly.

var daysInMonth = 0
var shortMonths = [Feb,Apr,Jul,Aug,Oct,Dec]
var longMonths = [Jan,Mar,May,Jun,Sep,Nov]
for each (month in shortMonths){if month = thismonth{daysInMonth = 30} ...extra processing for Feb ie.28 or 29}
same for each loop for longMonths
if (daysInMonth == 0){console.log(WTF?)}
var daysRemaining = today - daysInMonth
adjust dateBuckets to match

That’s Sunday morning, untested, pseudo code while I drink my tea so don’t expect the above to work (I doubt I could just subtract daysInMonth from today directly for example) but these would be some of the steps towards making the date more accurate.