Deleting unwanted files does not delete, only get and put

[ts678]

@kenkendk

At the end of the compact process, it will then delete all volumes that are no longer needed. This design is intended to be robust, but has the downside that you will need more space for a short period.

2.0.9.109_canary_2024-11-06 is apparently when it changed from what I described above.

Release note:

Fixed an issue that would cause verification errors if the compact was interrupted, thanks @Jojo-1000 and @ts678

Pull request:

Fix issues with extra blocks and files being recorded after an interrupted Compact() #5623

And the reason I’m here is because I was looking at my 2.0.8.108 backup where compact put duplicate blocks in a volume, which potentially ties in to the recent UNIQUE constraint failure.

EDIT:

In cases like this remote volume size expansion, I wonder if the “more space” means double?
Users with flexible storage might not mind a brief extra fee. Fixed storage compact might fail?