Choose 'Stop now' but status then shows 'Stopping after current file'

livetotell · April 23, 2022, 12:08pm

Looks like the stop immediately option isn’t working?
I’m on Windows 10, regular Beta release.

JimboJones · April 23, 2022, 12:39pm

Welcome livetotell,

The pause and stop options are not what most people think they are. As I understand it, the pause option, pauses (rather prevents) new jobs from being submitted to the backup queue. The stop button does stop the currently running job but it’s far from instant. It has to do some “rolling-back” of the changes that have not yet completed and this takes longer than most people think they should have to wait for.

livetotell · April 23, 2022, 1:29pm

Hey Jimbo,
Thanks for the reply. I get that there would be some tidying up to do, and it couldn’t just stop instantly, but I think the wording is wrong. If it gives you two options;

Stop after current file
Stop now
and you choose 2, why does the status bar show ‘stopping after current file’? It makes it look like you chose 1.
I’m fairly sure it says the same thing whether you choose 1 or 2 actually. So maybe just the wording is wrong, but it’s unclear.

JimboJones · April 23, 2022, 1:52pm

Yeah it’s been mentioned a few times. You can read more about it in this thread.

ts678 · April 23, 2022, 3:32pm

I have a guess, but I’m not a web developer. Are you? If so you can probably even patch your system:

github.com

duplicati/duplicati/blob/de13cbcbd0f85492e8b8603def0ced7d7472a8e4/Duplicati/Server/webroot/ngax/index.html#L179-L181


      
          <span ng-show="StopReqId == activeTaskID">
              <strong translate>Stopping after the current file:</strong> {{activeBackup.Backup.Name}}
          </span>

This file is sitting in your C:\Program Files\Duplicati 2\webroot\ngax\index.html if you want to test edits.
If you’ve been doing autoupdates, this folder is just a launcher though, so current update is elsewhere.

I don’t know history or code, but maybe the precise message is precisely wrong for one of the cases…
If that is the case, maybe it should just talk about Stopping instead of stating more than it really knows.

I didn’t find any Issue opened on this for development, but I might have missed it. Regardless, if this is proven by you to be easily fixable at least to avoid confusion, then maybe an issue could be filed for a permanent fix. Anything needing deep code investigation is not likely to happen. Too few developers…

Duplicati only exists and improves thanks to volunteers for code, test, docs, forum, and anywhere else.

If anybody could dig further, the GUI code is probably below, and also explains the delay in either case:

github.com

duplicati/duplicati/blob/de13cbcbd0f85492e8b8603def0ced7d7472a8e4/Duplicati/Server/webroot/ngax/scripts/controllers/StateController.js#L89-L108


      
          function handleClick(ix) {
              if (ix == 0) 
              {
                  AppService.post('/task/' + taskId + '/stopaftercurrentfile');
                  $scope.StopReqId = taskId;
              }
              else if (ix == 1) {
                  AppService.post('/task/' + taskId + '/stopnow');
                  $scope.StopReqId = taskId;
              }
          };
          
          if (txt.indexOf('Backup_') == 0)
          {
              DialogService.dialog(
                  gettextCatalog.getString("Stop running backup"),
                  gettextCatalog.getString("You can stop the backup after any file uploads currently in progress have finished."),
                  [gettextCatalog.getString("Stop after current file"), gettextCatalog.getString("Stop now"), gettextCatalog.getString("Cancel")],
                  handleClick
              );

livetotell · April 24, 2022, 10:36am

Thanks, but no, I don’t have the skills to try to fix this myself!

ts678 · April 24, 2022, 2:05pm

I’m not using autoupdater so I know which file to change. I edited with notepad, did Stop now, got

(A Stop after current file gives my same edited message)

which I think supports a theory of current message being more precise than it has knowledge to be.

I vaguely recall a discussion about whether we really need two varieties of Stop, but I can’t find it…

Getting rid of one would let that message precisely describe whichever one we decide should stay.
There have been reliability (e.g. backup corruptions) problems before, but I haven’t heard of either
variety of Stop doing that lately, otherwise the decision of which to drop might be “the broken one”.