Fallback to insecure connection when connecting to S3 with SSL

kenkendk · September 1, 2017, 11:28am

I just found this bug today, but basically the TrayIcon keeps a connection to the webserver, and this connection overrides the running backup’s settings

I even marked it as a TODO, but then completely forgot about it:

github.com

duplicati/duplicati/blob/master/Duplicati/GUI/Duplicati.GUI.TrayIcon/HttpServerConnection.cs#L392


        }

    }

}



private T PerformRequestInternal<T>(string method, string endpoint, Dictionary<string, string> queryparams)

{

    queryparams["format"] = "json";



    string query = EncodeQueryString(queryparams);



    // TODO: This can interfere with running backups, 

    // as the System.Net.ServicePointManager is shared with

    // all connections doing ftp/http requests

    using (var httpOptions = new Duplicati.Library.Modules.Builtin.HttpOptions())

    {

        httpOptions.Configure(m_options);



        var req =

            (System.Net.HttpWebRequest) System.Net.WebRequest.Create(

                new Uri(m_apiUri + endpoint + '?' + query));

        req.Method = method;

This means that the --accept-any-ssl-certificate is reset every time the tray-icon requests the status from the webserver …

I think the errors you see on Minio are caused by Duplicati dropping the connection when it sees the invalid certificate.