Duplicati stuck on Compact when Getting/Putting from OneDrive and results in missing files

ts678 · January 15, 2024, 8:40pm

No instant solution expected. It’s a big job, but it’s good to hear agreement that infinite seems risky.
Maybe I’ll open a general issue, but I’m less confident about a completely general fix. Maybe partly.
Backends that allow cancel might be easier to deal with. How would you even get the others down?

github.com

duplicati/duplicati/blob/e7c191389cdb3fdb9500d83ebd06e0ae99634fd1/Duplicati/Library/Interface/IStreamingBackend.cs#L25-L30


      
          /// <summary>

          /// An interface a backend may implement if it supports streaming operations.

          /// Backends that implement this interface can be throttled and correctly shows 

          /// the progressbar when transferring data.

          /// </summary>

          public interface IStreamingBackend : IBackend

might serve as a model for backends that respect some sort of cancel that could get them unstuck, however testing would still be needed to see if they really do. Extreme solution (maybe slow) might repartition Duplicati so that parts that are prone to get stuck can get killed without killing everything.

gpatel-fr · January 15, 2024, 9:40pm

As the comment says, streaming backend is not aimed at cancelling, it’s aimed at showing progress.
Reading the bug filed by @Jojo-1000 at Alternative FTP backend misuses low level interfaces · Issue #5082 · duplicati/duplicati · GitHub I remembered that the generic Duplicati Get Backend interface don’t use a cancellation token. Makes a generic abort complicated

ts678 · January 15, 2024, 10:15pm

The point of my comment is to give that as an example of how specialized IBackend offshoots exist.

That’s why you would create a more sophisticated interface for those that are found able to do abort.

github.com

duplicati/duplicati/blob/e7c191389cdb3fdb9500d83ebd06e0ae99634fd1/Duplicati/Library/Interface/IQuotaEnabledBackend.cs#L8-L11


      
          /// <summary>
          /// Backends that support reporting quota should implement this interface
          /// </summary>
          public interface IQuotaEnabledBackend : IBackend

is another example. Of course, this doesn’t solve the underpinnings. It just keeps track of what’s what.

The mention of Get is a good point. How many remote operations can a backend run at once? If many, providing cancel capability one each on is a bigger interface change than if some global kill is possible.