Critical issues with the current canary [2.0.3.9]

[kenkendk]

@JonMikelV

I may have found a repeatable scenario to trigger this. It seems like whenever I do multiple database repair / rebuild tests around dindex / dlist failure scenarios I eventually run into the “Metadat awas reported as not changed, but still requires being added?” issue.

Ok. There are now three open issues left on the list, and I think the snapshot issue is causing the UNIQUE constraint issue.

I think the snapshot issue is fixed, but I was never able to reproduce locally, so it may still lurk. If I am correct, this means we only have the “repair does not work” issue left.

I have some ideas for how we can make the repair process more robust, but it will take some rewriting to complete. I propose that we make a new canary with the fixes already in there, and then make the “repair does not work” issue the top priority for the next release. And we get some feedback on the snapshot issue.