Activate downloaded upgrade sometimes fail

kenkendk · November 5, 2018, 9:15pm

I agree. It does more bad than good.

kenkendk · November 8, 2018, 10:58am

Not sure why that task is being disposed, there is no need to dispose the task, so you can remove the using around it, but I am not sure it fixes anything.

Any idea why the new pair is not responding to the parent WindowsService process?

mikaelmello · November 8, 2018, 11:10am

None at all lol, will try to debug some time later today

kenkendk · November 8, 2018, 11:29am

It is possible that the closed process somehow closes the stdin/stdout of the WindowsService process, which makes it unable to ping-pong the new pair and that cause it to think it has stopped working.

mikaelmello · November 8, 2018, 12:29pm

I just tested the changes made in that commit (the ones that were reverted) without disallowing WindowsService to use the autoupdater, in other words, I did not do what is said here:

That means that the behavior is for the entire stack to exit, leaving recovery to the Services Manager.

This time, using the debugger, this is what happens:

We have a normal stack of:
1.1. Base WindowsService.exe
1.2. Newest WindowsService.exe (also base)
1.3. Newest Server.exe (base)
I download and activate the latest update
Server exits with the magic code
Newest WindowsService detects the MAGIC_CODE, according to the committed changes
Base WindowsService also detects MAGIC_CODE and therefore does not exit, it proceeds looping at this section of the code:

github.com

duplicati/duplicati/blob/1b54cd61077dabbd00b7fdb40ac8dda537b64c3a/Duplicati/Library/AutoUpdater/UpdaterManager.cs#L1106


      
          }

          

          var app = Environment.GetCommandLineArgs().First();

          var args = Library.Utility.Utility.WrapAsCommandLine(Environment.GetCommandLineArgs().Skip(1), false);

          

          if (!Path.IsPathRooted(app))

              app = Path.Combine(InstalledBaseDir, app);

          

          var executable = Path.GetFileName(app);

          

          while (true)

          {

              var best = GetBestUpdateVersion(true);

              var folder = best.Key;

          

              var pi = new System.Diagnostics.ProcessStartInfo(Path.Combine(folder, executable), args)

              {

                  CreateNoWindow = true,

                  UseShellExecute = false,

                  ErrorDialog = false,

              };

When it tries to launch the newest WindowsService, the child process exits instantly. I’m pretty sure of this because I’ve added a Debugger.Launch() and Debugger.Break() as the first two lines on WindowsService.Main() and I don’t get prompted to launch the debugger.

github.com

duplicati/duplicati/blob/1b54cd61077dabbd00b7fdb40ac8dda537b64c3a/Duplicati/Library/AutoUpdater/UpdaterManager.cs#L1135


      
          pi.EnvironmentVariables["LOCALIZATION_FOLDER"] = InstalledBaseDir;

          

          // On Windows, we manually redirect the streams

          if (Platform.IsClientWindows)

          {

              pi.RedirectStandardError = true;

              pi.RedirectStandardInput = true;

              pi.RedirectStandardOutput = true;

          }

          

          var proc = System.Diagnostics.Process.Start(pi);

          Task tasks = null;

          if (Platform.IsClientWindows)

          {

              // On Windows, we manually redirect the streams

              tasks = Task.WhenAll(

                  // This does some unwanted buffering that breaks things

                  //Console.OpenStandardInput().CopyToAsync(proc.StandardInput.BaseStream),

                  Task.Run(async () => {

                      var stdin = new StreamReader(Console.OpenStandardInput());

                      var line = string.Empty;

By using the debugger, I’ve dumped the proc variable right after it is defined, this is what I get: https://pastebin.com/YtTeZu9W

mikaelmello · November 8, 2018, 12:44pm

I’ve done the same process with the proposed change (calling RealMain directly from WindowsService and let Server sort its newest version) and everything seems normal from the lines executed. No idea why I/O breaks.