2.0.4.5 server appears to be broken on Synology

drwtsn32 · December 27, 2018, 6:26pm

I think I fixed this issue and submitted a new pull request:

github.com/duplicati/duplicati

Fix Duplicati shutdown issue on Synology

duplicati:master ← drwtsn32x:master

opened 06:24PM - 27 Dec 18 UTC

drwtsn32x

+1 -1

The current Synology start-stop-status does not properly shut down Duplicati. I…t terminates only the main process but not the child processes. Example processes before Duplicati is stopped via Synology Package Manager: ``` bash-4.3# ps ax | grep Dup 15236 ? Sl 0:00 mono /volume1/@appstore/Duplicati/Duplicati.Server.exe 15242 ? Sl 0:01 /volume1/@appstore/Mono/usr/local/bin/mono-sgen /volume1/@appstore/Duplicati/Duplicati.Server.exe ``` After telling Duplicati to stop, only PID 15236 is terminated. PID 15242 remains, and this causes problems if you try to start Duplicati again. This issue also causes problems when people try to upgrade as a stop/start cycle is needed in such a case. With this change the script will look up the process group ID (PGID) of the main PID and issue a kill command to that whole group. This will ensure the child processes are also shut down.

Would appreciate someone else testing it. I only have one NAS to test it on, but it works for me.